[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

buffer overflow fix



The buffer of the arguments window is too small. The attached patch fixes
this.

MSB

-- 
Who is this General Failure,
and why is he reading my disk ?

diff -Naur xwpe-1.5.29a/we_prog.c xwpe-1.5.29a-patched/we_prog.c
--- xwpe-1.5.29a/we_prog.c	Wed Jun  5 04:53:50 2002
+++ xwpe-1.5.29a-patched/we_prog.c	Fri Feb 21 14:29:48 2003
@@ -787,7 +787,9 @@
 
 int e_arguments(FENSTER *f)
 {
- char str[80];
+/* 4096 should be enough for everyone. The buffer is not checked for
+    overflow, though, so if you enter more than 4096 characters XWPE crashes.*/
+ char str[4096];
 
  if (!e_prog.arguments)
  {